This repository was archived by the owner on May 13, 2024. It is now read-only.
fix: design changes for app manager #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 107 107
Lines 1492 1492
Branches 186 186
=======================================
Hits 1440 1440
Misses 9 9
Partials 43 43
|
matin-deriv
reviewed
Jun 15, 2023
Comment on lines
-49
to
+55
| const cancelButton = screen.getByRole('button', { name: /no, keep it/i }); | ||
| const cancelButton = screen.getByRole('button', { name: /Cancel/i }); | ||
| expect(okButton).toBeInTheDocument(); | ||
| expect(cancelButton).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('Should call onClose on cancel button click', async () => { | ||
| const cancelButton = screen.getByRole('button', { name: /no, keep it/i }); | ||
| const cancelButton = screen.getByRole('button', { name: /cancel/i }); |
Contributor
There was a problem hiding this comment.
[Question]: why one of the word starts with a capital letter and not the other one?
Contributor
Author
There was a problem hiding this comment.
Anything you write in between the // it only checks for the words inside the ui and ignores capital letters. so their will be no differnce if we use capital or small letters in the test case
matin-deriv
previously approved these changes
Jun 19, 2023
hubert-deriv
approved these changes
Jun 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.